feat(Table) : adding context menu for table row to example and prototype #12253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolaps33
requested review from
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
layershifter,
levithomason,
miroslavstastny,
mnajdova,
pompomon and
silviuaavram
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: fd45f9cd4a8649a2f39f5af5829a91ce6c649f00 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
pompomon
approved these changes
Mar 11, 2020
jurokapsiar
reviewed
Mar 11, 2020
| @@ -10,6 +19,10 @@ const InteractiveTable = () => { | |||
| setPopupOpen(false); | |||
| }; | |||
|
|
|||
| const contextMenuItems = ['Add to selection', 'Remove', 'Download']; | |||
|
|
|||
| const getRowWithContextMenu = tableRow => <MenuButton contextMenu trigger={tableRow} menu={contextMenuItems} />; | |||
There was a problem hiding this comment.
I would rename this to just withContextMenu
silviuaavram
approved these changes
Mar 11, 2020
miroslavstastny
previously requested changes
Mar 11, 2020
| @@ -54,7 +56,8 @@ const rowsPlain = [ | |||
| moreOptionCell | |||
| ], | |||
| onClick: () => handleRowClick(1), | |||
| 'aria-labelledby': 'name-1 age-1' | |||
| 'aria-labelledby': 'name-1 age-1', | |||
| children: (Component, props) => <MenuButton menu={contextMenuItems} contextMenu trigger={<Component {...props} />} /> | |||
There was a problem hiding this comment.
I think that this will produce a key error in console as key will be still on a row. The change below will move it to a proper component.
Suggested change
| children: (Component, props) => <MenuButton menu={contextMenuItems} contextMenu trigger={<Component {...props} />} /> | |
| children: (Component, { key, ...rest }) => <MenuButton menu={contextMenuItems} key={key} contextMenu trigger={<Component {...rest} />} /> |
| </Table.Row> | ||
| {withContextMenu( | ||
| <Table.Row key="1" accessibility={gridRowBehavior}> | ||
| <Table.Cell content="1" key="1-1" accessibility={gridCellBehavior} /> |
There was a problem hiding this comment.
Suggested change
| <Table.Cell content="1" key="1-1" accessibility={gridCellBehavior} /> | |
| <Table.Cell content="1" accessibility={gridCellBehavior} /> |
key here and on all other Table.Cell and Table.Roe is redundant
| <Table.Cell content="30000000000000 years" key="1-4" accessibility={gridCellBehavior} /> | ||
| </Table.Row> | ||
| {withContextMenu( | ||
| <Table.Row key="1" accessibility={gridRowBehavior}> |
There was a problem hiding this comment.
Suggested change
| <Table.Row key="1" accessibility={gridRowBehavior}> | |
| <Table.Row accessibility={gridRowBehavior}> |
| moreActionCell, | ||
| moreOptionCell | ||
| moreActionCell('1-5'), | ||
| moreOptionCell('1-6') |
There was a problem hiding this comment.
I would prefer an approach with spread:
Suggested change
| moreOptionCell('1-6') | |
| { key: '1-6', ...moreOptionCell }, |
But it's not blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
Adding usage of context menu for table row.
Focus areas to test
Added into:
Microsoft Reviewers: Open in CodeFlow