Renaming @fluentui/react to @fluentui/react-northstar #12302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzearing
requested review from
ecraig12345,
JasonGore,
jdhuntington,
jurokapsiar,
kenotron,
layershifter,
levithomason,
miroslavstastny,
mnajdova,
pompomon and
silviuaavram
as code owners
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 69fe48c5b3f2d64004ede907c5e6eb3e0d1c31e8 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
…c-react into fluent-ui-exp # Conflicts: # packages/fluentui/react-experimental/src/themes/teams-high-contrast/componentStyles.ts # packages/fluentui/react-experimental/src/themes/teams-high-contrast/components/Menu/menuItemStyles.ts
miroslavstastny
approved these changes
Mar 16, 2020
This was referenced Mar 16, 2020
Merged
dzearing
changed the title
…c-react into fluent-ui-exp
dzearing
changed the title
|
@miroslavstastny I believe we are ready to go here; can you help with merge/publish/update teams? I will start on the oufr aliasing pr next. |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting out to address these goals for customers:
Know which component package to use when (@fluentui/react@7 vs office-ui-fabric-react vs@fluentui/react@0 is confusing. Instead we will have
@fluentui/react,@fluentui/react-next, and@fluentui/react-northstar.)Ensure that the current production LTS channel can live side by side with "next" and "northstar" code.
To meet these needs, we will be renaming the
@fluentui/reactpackage to@fluentui/react-northstar.BREAKING CHANGE
This means that
@fluentui/reactpackage imports would be changed to@fluentui/react-northstar. It is possible however to use new versions of the packages without changing imports via npm aliasing:Microsoft Reviewers: Open in CodeFlow