Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Card): Adding base layout and API for card component #12349

Merged
merged 30 commits into from
Mar 20, 2020

Conversation

pompomon
Copy link
Contributor

@pompomon pompomon commented Mar 18, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Adding Card component which supports basic card layout (vertical and horizontal)

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Mar 18, 2020
@pompomon pompomon changed the title Adding prototype for card component [WIP] Adding prototype for card component Mar 18, 2020
@size-auditor
Copy link

size-auditor bot commented Mar 18, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e2a5a85280687cf2803f1cd9ac069010a7698ba3 (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Mar 18, 2020

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 943 848
BaseButton (experiments) 1017 933
DefaultButton 1092 1097
DefaultButton (experiments) 2036 1881
DetailsRow 3541 3515
DetailsRow (fast icons) 3460 3545
DetailsRow without styles 3323 3296
DocumentCardTitle with truncation 1531 1545
MenuButton 1548 1473
MenuButton (experiments) 3623 3443
PrimaryButton 1327 1222
PrimaryButton (experiments) 2033 2057
SplitButton 3119 3102
SplitButton (experiments) 6825 7111
Stack 467 464
Stack with Intrinsic children 1140 1125
Stack with Text children 4309 4271
Text 391 374
Toggle 860 914
Toggle (experiments) 2237 2312
button 69 55

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
CardMinimalPerf.default 438 52 8.42:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.58 0.5 1.16:1 2000 1152
🦄 Button.Fluent 0.11 0.22 0.5:1 5000 545
🔧 Checkbox.Fluent 0.77 0.43 1.79:1 1000 774
🔧 Dialog.Fluent 0.43 0.21 2.05:1 5000 2167
🔧 Dropdown.Fluent 3.69 0.53 6.96:1 1000 3690
🔧 Icon.Fluent 0.19 0.05 3.8:1 5000 946
🎯 Image.Fluent 0.08 0.11 0.73:1 5000 408
🔧 Slider.Fluent 1.6 0.43 3.72:1 1000 1597
🔧 Text.Fluent 0.09 0.02 4.5:1 5000 464
🦄 Tooltip.Fluent 0.14 16 0.01:1 5000 675

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
BoxMinimalPerf.default 475 409 1.16:1
ButtonMinimalPerf.default 180 155 1.16:1
PortalMinimalPerf.default 357 309 1.16:1
LabelMinimalPerf.default 478 419 1.14:1
LoaderMinimalPerf.default 1262 1130 1.12:1
StatusMinimalPerf.default 794 713 1.11:1
Text.Fluent 464 418 1.11:1
DividerMinimalPerf.default 1173 1063 1.1:1
TextMinimalPerf.default 469 425 1.1:1
ButtonSlotsPerf.default 701 652 1.08:1
ProviderMinimalPerf.default 714 663 1.08:1
AccordionMinimalPerf.default 283 265 1.07:1
AttachmentMinimalPerf.default 996 944 1.06:1
AvatarMinimalPerf.default 609 575 1.06:1
ImageMinimalPerf.default 417 394 1.06:1
ListCommonPerf.default 1217 1152 1.06:1
PopupMinimalPerf.default 264 249 1.06:1
RefMinimalPerf.default 219 206 1.06:1
CustomToolbarPrototype.default 3993 3773 1.06:1
IconMinimalPerf.default 479 456 1.05:1
Checkbox.Fluent 774 735 1.05:1
ChatMinimalPerf.default 673 647 1.04:1
ListMinimalPerf.default 501 484 1.04:1
RadioGroupMinimalPerf.default 665 642 1.04:1
TooltipMinimalPerf.default 961 928 1.04:1
AttachmentSlotsPerf.default 3950 3843 1.03:1
CheckboxMinimalPerf.default 3484 3392 1.03:1
DropdownManyItemsPerf.default 1654 1606 1.03:1
LayoutMinimalPerf.default 787 762 1.03:1
MenuButtonMinimalPerf.default 1710 1665 1.03:1
VideoMinimalPerf.default 997 967 1.03:1
AnimationMinimalPerf.default 755 739 1.02:1
Tooltip.Fluent 675 661 1.02:1
InputMinimalPerf.default 1187 1171 1.01:1
ItemLayoutMinimalPerf.default 2450 2424 1.01:1
TreeMinimalPerf.default 1338 1323 1.01:1
ChatDuplicateMessagesPerf.default 482 482 1:1
ProviderMergeThemesPerf.default 1418 1415 1:1
ReactionMinimalPerf.default 2720 2732 1:1
TableMinimalPerf.default 762 761 1:1
Button.Fluent 545 547 1:1
DropdownMinimalPerf.default 3741 3778 0.99:1
EmbedMinimalPerf.default 5725 5763 0.99:1
FlexMinimalPerf.default 316 320 0.99:1
SliderMinimalPerf.default 1606 1627 0.99:1
SplitButtonMinimalPerf.default 13153 13294 0.99:1
Dropdown.Fluent 3690 3734 0.99:1
AlertMinimalPerf.default 654 665 0.98:1
DialogMinimalPerf.default 2137 2184 0.98:1
Image.Fluent 408 415 0.98:1
CarouselMinimalPerf.default 2180 2243 0.97:1
FormMinimalPerf.default 1053 1087 0.97:1
HeaderSlotsPerf.default 1908 1972 0.97:1
HierarchicalTreeMinimalPerf.default 1189 1227 0.97:1
SegmentMinimalPerf.default 1224 1266 0.97:1
Dialog.Fluent 2167 2232 0.97:1
ChatWithPopoverPerf.default 647 673 0.96:1
HeaderMinimalPerf.default 644 669 0.96:1
ListNestedPerf.default 1095 1137 0.96:1
ToolbarMinimalPerf.default 1250 1297 0.96:1
Slider.Fluent 1597 1657 0.96:1
GridMinimalPerf.default 996 1053 0.95:1
ListWith60ListItems.default 1317 1380 0.95:1
MenuMinimalPerf.default 2077 2178 0.95:1
TreeWith60ListItems.default 233 244 0.95:1
TextAreaMinimalPerf.default 3269 3509 0.93:1
Avatar.Fluent 1152 1258 0.92:1
Icon.Fluent 946 1034 0.91:1

pompomon and others added 28 commits March 20, 2020 15:04
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
….tsx

Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
….tsx

Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@pompomon pompomon merged commit 200179a into microsoft:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants