-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Card): Adding base layout and API for card component #12349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompomon
requested review from
dzearing,
JasonGore,
jdhuntington,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
silviuaavram
as code owners
March 18, 2020 17:34
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Work related to Fluent UI V0
label
Mar 18, 2020
pompomon
changed the title
Adding prototype for card component
[WIP] Adding prototype for card component
Mar 18, 2020
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e2a5a85280687cf2803f1cd9ac069010a7698ba3 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
packages/fluentui/react/src/themes/teams/components/Card/cardStyles.ts
Outdated
Show resolved
Hide resolved
packages/fluentui/react/src/themes/teams/components/Card/cardTopControlsStyles.ts
Outdated
Show resolved
Hide resolved
packages/fluentui/react/src/themes/teams/components/Card/cardVariables.ts
Outdated
Show resolved
Hide resolved
packages/fluentui/react/src/components/Card/CardTopControls.tsx
Outdated
Show resolved
Hide resolved
packages/fluentui/accessibility/src/behaviors/Card/cardBehavior.ts
Outdated
Show resolved
Hide resolved
packages/fluentui/accessibility/src/behaviors/Card/cardBodyBehavior.ts
Outdated
Show resolved
Hide resolved
packages/fluentui/docs/src/examples/components/Card/Usage/CardExampleCentered.tsx
Outdated
Show resolved
Hide resolved
packages/fluentui/docs/src/examples/components/Card/Usage/CardExampleCentered.tsx
Outdated
Show resolved
Hide resolved
packages/fluentui/docs/src/examples/components/Card/Usage/index.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
….tsx Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
….tsx Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
pompomon
force-pushed
the
feat/card-prototype
branch
from
March 20, 2020 14:07
3b01184
to
502ebb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn change
Description of changes
Adding Card component which supports basic card layout (vertical and horizontal)
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow