feat(bindings): add useUnhandledProps hook #12371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
added
the
Fluent UI react-northstar (v0)
layershifter
requested review from
dzearing,
JasonGore,
jdhuntington,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova,
pompomon and
silviuaavram
as code owners
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 13e558c9ff85536a1ce1b06d4816b78fab2ec7be (build) |
mnajdova
reviewed
Mar 20, 2020
| * @param props - A ReactElement props object | ||
| * @returns A shallow copy of the prop object | ||
| */ | ||
| function useUnhandledProps<P extends Record<string, any>>(handledProps: (keyof P)[], props: P): Partial<P> { |
There was a problem hiding this comment.
Can we add example in the react-bindings README? Or do you consider this as an internal hook?
mnajdova
reviewed
Mar 20, 2020
| @@ -15,6 +15,7 @@ export { default as unstable_useDispatchEffect } from './hooks/useDispatchEffect | |||
| export { default as useIsomorphicLayoutEffect } from './hooks/useIsomorphicLayoutEffect'; | |||
| export { default as useStateManager } from './hooks/useStateManager'; | |||
| export { default as useStyles } from './hooks/useStyles'; | |||
| export { default as useUnhandledProps } from './hooks/useUnhandledProps'; | |||
There was a problem hiding this comment.
As we are exporting it, I believe it deserves changelog entry
mnajdova
reviewed
Mar 20, 2020
| @@ -231,7 +231,7 @@ const Animation: React.FC<AnimationProps> & { | |||
| const { animationDuration, animationDelay } = animationStyles.root; | |||
| const timeoutResult = timeout || calculateAnimationTimeout(animationDuration, animationDelay) || 0; | |||
|
|
|||
| const unhandledProps = getUnhandledProps(Animation.handledProps, props); | |||
| const unhandledProps = useUnhandledProps(Animation.handledProps, props); | |||
There was a problem hiding this comment.
Should we use the generic typings?
There was a problem hiding this comment.
Nope, they will be inferred as it was previously for getUnhandledProps
mnajdova
approved these changes
Mar 20, 2020
…/github.com/OfficeDev/office-ui-fabric-react into feat/add-use-unhandled-props
…/github.com/OfficeDev/office-ui-fabric-react into feat/add-use-unhandled-props � Conflicts: � packages/fluentui/CHANGELOG.md � packages/fluentui/react-bindings/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR adds
useUnhandledProps()hook to replacegetUnhandledProps()function in functional components. Functionality ofuseUnhandledProps()will be changed incompose()PR.Microsoft Reviewers: Open in CodeFlow