ShimmeredDetailsList: modify some math logic #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzearing
reviewed
Aug 9, 2018
| width: | ||
| cellStyleProps.cellRightPadding + | ||
| (column.calculatedWidth! - column.calculatedWidth! * SHIMMER_LINE_VS_CELL_WIDTH_RATIO) + | ||
| (column.isPadded ? cellStyleProps.cellExtraRightPadding : 0), |
There was a problem hiding this comment.
hmmm. i see the word "right". Is this RTL friendly?
There was a problem hiding this comment.
@dzearing I tested it with the link provided by VSTS: Deploy Demo and indeed it works as intended in RTL. Plus to that the value calculated in here is applied to the width of a container and should not affect RTL layout.
dzearing
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
ShimmeredDetailsList was not taking into consideration the isPadded property of the column so had to adjust some widths of shimmer elements plus took advantage to replace a hard coded multiplier with a constant ratio.
This is how it looks misaligned:
This is how it looks after the fix:
Microsoft Reviewers: Open in CodeFlow