Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React.ComponentType in picker for render props #7877

Merged

Conversation

Adjective-Object
Copy link
Contributor

@Adjective-Object Adjective-Object commented Feb 1, 2019

Pull request checklist

Description of changes

in the picker, we're using React.ComponentType in a number of places
to basically just wrap a component render.

This change expands the definitions of the render props to
ComponentType, so the consumer can just pass in the relevant
ComponentClass instead of defining a pass-through render prop.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

in the picker, we're using React.ComponentType in a number of places
to basically just wrap a component render.

This change expands the definitions of the render props to
ComponentType, so the consumer can just pass in the relevant
ComponentClass instead of defining a pass-through render prop.
@size-auditor
Copy link

size-auditor bot commented Feb 1, 2019

Bundle test Size (minified) Diff from master
ExtendedPicker 210.459 kB ExceedsBaseline     48 bytes

ExceedsTolerance  Exceeds Tolerance     ExceedsBaseline  Exceeds Baseline     BelowBaseline  Below Baseline     1 kB = 1000 bytes

@leddie24
Copy link
Collaborator

leddie24 commented Feb 1, 2019

@Adjective-Object, it looks like you're missing the change file. Can you run npm run change and commit the file please? Thank you!

Copy link
Member

@Lego6245 Lego6245 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM and seems sensible, though I'm not the best person to review as it's been ages since I've touched this code.

@leddie24 leddie24 merged commit 9001765 into microsoft:master Feb 4, 2019
@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v6.134.0 has been released which incorporates this pull request.:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants