Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Reference Docs ribbon button doesn't work in Online #807

Open
Zlatkovsky opened this issue May 4, 2018 · 0 comments
Open

Reference Docs ribbon button doesn't work in Online #807

Zlatkovsky opened this issue May 4, 2018 · 0 comments
Labels
bug
Milestone
V 1.1-patch

Comments

@Zlatkovsky
Copy link
Member

Zlatkovsky commented May 4, 2018 •
edited
Loading

Even with the other Ribbon fixes (OfficeDev/script-lab@b717b4f#diff-1358ec6ed0796fcf1c428665bd418886), there appears to be an issue with Office Online. The page doesn't want to be iframed. We need to find a better (and generally more usable) solution

image
@Zlatkovsky Zlatkovsky added the bug label May 4, 2018
@Zlatkovsky Zlatkovsky added this to the V 1.1-patch milestone May 4, 2018
@Zlatkovsky Zlatkovsky changed the title Reference docs button doesn't work in Online Reference Docs ribbon button doesn't work in Online May 4, 2018
Zlatkovsky referenced this issue May 16, 2018
@Zlatkovsky
Fix "reference docs" not working in Office Online.
f752dc7 
Issue was that some of the ref docs (e.g., for PPT) were on a site that doesn't allow embedding.
Fixed by having it launch a standalone window instead.
OfficeDev/script-lab#807
Zlatkovsky referenced this issue May 16, 2018
@Zlatkovsky
Fix "reference docs" not working in Office Online.
64dcda0 
Issue was that some of the ref docs (e.g., for PPT) were on a site that doesn't allow embedding.
Fixed by having it launch a standalone window instead.
OfficeDev/script-lab#807

(cherry picked from commit f752dc7)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
V 1.1-patch
Development

No branches or pull requests
1 participant
@Zlatkovsky