Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for reviewers #487

Closed
nicolas33 opened this issue Jul 7, 2017 · 3 comments
Closed

Request for reviewers #487

nicolas33 opened this issue Jul 7, 2017 · 3 comments
Assignees

Comments

@nicolas33
Copy link
Member

Github has introduced a new feature for reviewers.

https://help.github.com/articles/about-codeowners/

If you'd like to be a reviewer on pull requests, please send me the lines you'd like to have in the CODEOWNERS file. The format is the path to track followed by your github username (or email address added to the github account).

Here's a sample:

* @nicolas33
offlineimap* @nicolas33 @you

Code review is good. ,-)

@nicolas33 nicolas33 self-assigned this Jul 7, 2017
@chris001
Copy link
Member

chris001 commented Jul 7, 2017

Would be great to send Piers notifications for offlineimap/bundled_imaplib2.py piers@janeelix.com.
You can add my username @chris001 also.

@chris001
Copy link
Member

chris001 commented Jul 7, 2017

It looks like bundled_imaplib2.py here is set to 2.55.
https://github.com/OfflineIMAP/offlineimap/blob/master/offlineimap/virtual_imaplib2.py
Should it match the version in bundled_imaplib2.py 2.57 ?

@nicolas33
Copy link
Member Author

I think that if Piers want to be notified he will request us. ,-)

Ok to increase the imaplib2 requirement: done. I've added your username to the CODEOWNERS file.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants