Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing react-bootstrap css ? #4

Closed
tlvenn opened this issue Nov 26, 2016 · 2 comments
Closed

Missing react-bootstrap css ? #4

tlvenn opened this issue Nov 26, 2016 · 2 comments

Comments

@tlvenn
Copy link
Contributor

tlvenn commented Nov 26, 2016

In your example, you are requiring 2 css files:

import 'graphiql-workspace/graphiql-workspace.css'
import 'graphiql/graphiql.css'

Since graphiql-workspace.css is a standalone css file now, shouldnt we need to import react-bootstrap.css as well ?

@OlegIlyenko
Copy link
Owner

Yeah we need it as well (and I probably should mention it in README). The thing about it is that it should be handled externally as far as i understood. In graphql-toolsbox, for instance, I add it with bootstrap-loader in webpack config. But I'm not very experienced in this area, so I would appreciate any suggestion in this area.

On the other hand, in past people has issue with bundled bootstrap css (the fornts, for instance, were not properly linked), so maybe it's indeed better to handle bootstrap in the final app directly.

@tlvenn
Copy link
Contributor Author

tlvenn commented Feb 10, 2017

Given you have added a comment in the Readme (64bc52b) we can close this issue.

For reference, in my template file, I pull the bootstrap css from:

https://maxcdn.bootstrapcdn.com/bootstrap/latest/css/bootstrap.min.css

@tlvenn tlvenn closed this as completed Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants