Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StartupConfig method for checking whether to expose a class. #3

Merged
merged 1 commit into from Feb 7, 2022

Conversation

Olipro
Copy link
Owner

@Olipro Olipro commented Feb 7, 2022

It is now possible to implement a method that is passed the
fully-qualified class string and returns true if that class should be
modified to have itself, its methods and its fields made public and,
where possible, non-final.

Additionally, documentation has been added for all packages to improve
the JavaDoc.

@Olipro Olipro temporarily deployed to Standard February 7, 2022 02:33 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #3 (87347f0) into master (0b82964) will decrease coverage by 0.91%.
The diff coverage is 76.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #3      +/-   ##
============================================
- Coverage     86.26%   85.34%   -0.92%     
- Complexity      184      186       +2     
============================================
  Files            23       24       +1     
  Lines           444      464      +20     
  Branches         39       40       +1     
============================================
+ Hits            383      396      +13     
- Misses           31       37       +6     
- Partials         30       31       +1     
Flag Coverage Δ
unittests 85.34% <76.92%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...heinter/interceptify/interfaces/StartupConfig.java 83.33% <0.00%> (-16.67%) ⬇️
...ptheinter/interceptify/internal/ClassInjector.java 86.08% <33.33%> (+0.61%) ⬆️
.../uptheinter/interceptify/internal/RuntimeHook.java 85.71% <60.00%> (-14.29%) ⬇️
...uptheinter/interceptify/internal/ClassExposer.java 82.27% <82.27%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b82964...87347f0. Read the comment docs.

@Olipro Olipro temporarily deployed to Standard February 7, 2022 03:17 Inactive
It is now possible to implement a method that is passed the
fully-qualified class string and returns true if that class should be
modified to have itself, its methods and its fields made public and,
where possible, non-final.

Additionally, documentation has been added for all packages to improve
the JavaDoc.
@Olipro Olipro temporarily deployed to Standard February 7, 2022 03:25 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.6% 94.6% Coverage
0.0% 0.0% Duplication

@Olipro Olipro merged commit 02df94b into master Feb 7, 2022
@Olipro Olipro deleted the RC-1.2.0 branch February 7, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants