Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify TypePool usage and fix up class exposure. #4

Merged
merged 1 commit into from Feb 8, 2022
Merged

Conversation

Olipro
Copy link
Owner

@Olipro Olipro commented Feb 8, 2022

There was an issue where nested classes did not have their visibility
set due to having extra attributes. This then subsequently led to the
discovery of an issue where all types need to be resolveable in order
for the visitor to be able to apply the fixes.

Additionally the JVM passes class names with the foo/bar format, so we
convert to dot notation before running transformation.

All public-facing APIs remain the same.

There was an issue where nested classes did not have their visibility
set due to having extra attributes. This then subsequently led to the
discovery of an issue where all types need to be resolveable in order
for the visitor to be able to apply the fixes.

Additionally the JVM passes class names with the foo/bar format, so we
convert to dot notation before running transformation.

All public-facing APIs remain the same.
@Olipro Olipro temporarily deployed to Standard February 8, 2022 09:48 Inactive
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.7% 97.7% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #4 (9a25e81) into master (02df94b) will increase coverage by 0.29%.
The diff coverage is 97.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
+ Coverage     88.36%   88.65%   +0.29%     
- Complexity      195      197       +2     
============================================
  Files            24       23       -1     
  Lines           464      476      +12     
  Branches         40       43       +3     
============================================
+ Hits            410      422      +12     
+ Misses           27       26       -1     
- Partials         27       28       +1     
Flag Coverage Δ
unittests 88.65% <97.36%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ptheinter/interceptify/internal/ClassInjector.java 89.76% <95.45%> (+0.19%) ⬆️
...uptheinter/interceptify/internal/ClassExposer.java 93.18% <100.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02df94b...9a25e81. Read the comment docs.

@Olipro Olipro merged commit 6a3a074 into master Feb 8, 2022
@Olipro Olipro deleted the RC-1.2.1 branch February 8, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants