Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadOnly-Users can delete files #16

Open
billporte opened this issue Nov 2, 2020 · 4 comments
Open

ReadOnly-Users can delete files #16

billporte opened this issue Nov 2, 2020 · 4 comments
Labels
status: waitingForFeedback Wating for Customers feedback type: enhancement New feature or request

Comments

@billporte
Copy link

Hello,
It seems that Read Only Users can change the status of each parameters of deleteafterprint plugin.
but perhaps I misunderstand something.

@stale
Copy link

stale bot commented Dec 2, 2020

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Dec 2, 2020
@stale stale bot closed this as completed Dec 12, 2020
@OllisGit OllisGit changed the title ReadOnly can delete file ReadOnly-Users can delete files Jan 11, 2021
@OllisGit OllisGit added type: enhancement New feature or request and removed status: markedForAutoClose Issue will be closed automatically labels Jan 11, 2021
@OllisGit
Copy link
Owner

Hi @billporte ,
currently there is no permission-check implemented.

I marked it as "enhancement", because it is a good idea to implement such feature, but the Permission-Concept of OP was changed in Version 1.4, so I need to drop support for OP 1.3 of this plugin.

Which version of OP do you use (latest 1.5) ?

@OllisGit OllisGit added the status: waitingForFeedback Wating for Customers feedback label Jan 11, 2021
@billporte
Copy link
Author

Hi OlliGit,

Good news for moving it to enhancement
I stay permanently in the latest stable versions of octoprint or plugin

@OllisGit OllisGit reopened this Jan 12, 2021
@OllisGit
Copy link
Owner

Ho @billporte

I look into this topic with OP Version 1.6.1. It looks like this:
image
Yes, the checkboxes could be changed, but the user is not able to print.
So, I am a little bit confused what permission-check should assign to my plugin?
Any suggestion?

BR
Olli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waitingForFeedback Wating for Customers feedback type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants