Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prusa Slicer Thumbnail #224

Open
TMTYD opened this issue Aug 12, 2023 · 11 comments
Open

Prusa Slicer Thumbnail #224

TMTYD opened this issue Aug 12, 2023 · 11 comments

Comments

@TMTYD
Copy link

TMTYD commented Aug 12, 2023

The thumbnails are not saved in the Print job History, although I have installed the Prusaslicer Thumbnail plugin and have also specified the values for Thumbnail in PrusaSlicer under Print settings. Why is that?

grafik

Technical Log

@TMTYD
Copy link
Author

TMTYD commented Aug 16, 2023

i have this in log from octoprint.log

octoprint - ERROR - Exception on /plugin/PrintJobHistory/printJobSnapshot/20230813-013948.jpg [GET]
Traceback (most recent call last):
  File "/home/pi/OctoPrint/venv/lib/python3.9/site-packages/flask/app.py", line 2529, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/pi/OctoPrint/venv/lib/python3.9/site-packages/flask/app.py", line 1825, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/pi/OctoPrint/venv/lib/python3.9/site-packages/flask/app.py", line 1823, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/pi/OctoPrint/venv/lib/python3.9/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
  File "/home/pi/OctoPrint/venv/lib/python3.9/site-packages/octoprint/util/__init__.py", line 1686, in wrapper
    return f(*args, **kwargs)
  File "/home/pi/OctoPrint/venv/lib/python3.9/site-packages/octoprint_PrintJobHistory/api/PrintJobHistoryAPI.py", line 443, in get_snapshot
    return send_file(absoluteFilename, mimetype='image/jpg', cache_timeout=1)
TypeError: send_file() got an unexpected keyword argument 'cache_timeout'

@dojohnso
Copy link

@TMTYD try the fix I have a PR open for here:

1d86931

I'm working on trying to get this plugin flagged as abandoned so we can actually get some updates to it

@TMTYD
Copy link
Author

TMTYD commented Oct 3, 2023

plugin_PrintJobHistory_singlePrintJob.log
Hi, I changed that, but unfortunately no improvement. What size must be set in the Prusa slicer for G-code thumbnails? I set 16x16, 200x200 there and png as the format

@dojohnso
Copy link

dojohnso commented Oct 5, 2023

plugin_PrintJobHistory_singlePrintJob.log Hi, I changed that, but unfortunately no improvement. What size must be set in the Prusa slicer for G-code thumbnails? I set 16x16, 200x200 there and png as the format

that's what mine is set to as well. i've noticed this fix doesn't work for everyone, even on one of my Pi's it's not working but I haven't gotten into why yet. Likely will have to do with versions of board or OS or python, etc.

@TMTYD
Copy link
Author

TMTYD commented Oct 16, 2023

Hi why does it sometimes work and sometimes not?

grafik

@Titius-Sicanus
Copy link

If the file name contains spaces or special characters then the thumbnail is not extracted.
The only characters I've found allowed are the minus sign (-) and the underscore character (_)

@TMTYD
Copy link
Author

TMTYD commented Oct 16, 2023

Ok, can you change that somehow?

@Titius-Sicanus
Copy link

I'm sorry but I'm also waiting for someone to be able to solve this problem.

@dojohnso
Copy link

If octoprint ever acknowledges this plugin is abandoned and someone takes it over (I've been trying for months), best I can do is take a look and maybe submit another PR that people can see and copy the changes locally.

@TMTYD
Copy link
Author

TMTYD commented Oct 19, 2023

If the file name contains spaces or special characters then the thumbnail is not extracted.
The only characters I've found allowed are the minus sign (-) and the underscore character (_)

So that works with the _ substir, then the thumbnail is also saved

@dojohnso
Copy link

@TMTYD @Titius-Sicanus

#226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants