Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support other decorators like underline, background color, etc... #3

Open
OmarTawfik opened this issue Jul 3, 2021 · 0 comments
Open

Support other decorators like underline, background color, etc... #3

OmarTawfik opened this issue Jul 3, 2021 · 0 comments
Labels
feature Approved for implementation

Comments

@OmarTawfik
Copy link
Owner

The vscode-textmate library we use does not just export foreground color, it also supports a bunch of other metadata, like underlines, and background color. We should be able to extract this info and pass it along to the colorization engine.

https://github.com/microsoft/vscode-textmate/blob/9e3c5941668cbfcee5095eaec0e58090fda8f316/src/grammar.ts#L1081-L1099
@OmarTawfik OmarTawfik added the feature Approved for implementation label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Approved for implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OmarTawfik