Newsletter localization #4485
Merged
Newsletter localization #4485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's be consistent with Emby and Jellyfin
|
I worked on this before the refactoring was merged to develop, sorry for the mess in the commit list. The relevant commits are near the bottom (from 45c5c1e). |
|
That's fine, they all get squashed before going to develop anyway. I'm going to pull this one down and do a bit of testing, but looking over the code no complaints :) There are some failing tests mind. Actually the failing tests are flakey tests... I'll fix them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow some strings in the newsletter to be translated through the use of .resx files. These files are supported by Crowdin and could be added there to allow for global localization. I've already translated the FR part for testing purposes and included it in this PR.
For now the newsletter will use the global language settings, it won't take into account the user's individual preferences.
It will use English as default if there is no resource file present for the set language, so it should be safe to deploy before integrating it into Crowdin and have the generated files for every language.
I hope I did right by the guidelines with the I18n packaging, this is fairly new to me. I'm open to feedback.