Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to accept decompilation legal agreement globally for all current and future workspaces. #3982

Closed
joelday opened this issue Aug 15, 2020 · 8 comments · Fixed by #4760

Comments

@joelday
Copy link

joelday commented Aug 15, 2020

Issue Description

As a developer, I would like to be presented with and accept the legal agreement displayed by the csharp.showDecompilationTerms command only once instead of when the language support is activated for the first time in each workspace.

Thank you!

@cartermp
Copy link

Yeah, this would definitely be nice to have. I think there's some conversations going on about the same topic for Visual Studio too, since as you could imagine, lots of users there are fine accepting the terms but don't want to keep seeing it for every VS session.

@joelday
Copy link
Author

joelday commented Nov 20, 2020

@cartermp Quick note that this is now displayed every time I open vscode. Unsure if others are experiencing that.

@heshuimu
Copy link

heshuimu commented Nov 24, 2020

@cartermp Quick note that this is now displayed every time I open vscode. Unsure if others are experiencing that.

I can confirm this, even when opening non-C# source code files. It's getting super annoying now.

@manojbaishya
Copy link

Please vote this issue up:
Accepting the decompiler agreement permanently
Since it has more upvotes, maybe product owner will take notice.

@joelday
Copy link
Author

joelday commented Sep 10, 2021

This shows up constantly even for non C# workspaces now, at least in my case, so it has gone from annoyance to outright bug.

@joelday
Copy link
Author

joelday commented Sep 10, 2021

@cartermp Should I open a bug to address the dialog appearing for non-C# workspaces?

@JoeRobich
Copy link
Member

Should I open a bug to address the dialog appearing for non-C# workspaces?

What type of files are in the workspace? Unfortunately with VS Code it isn't as simple as saying this csproj or sln was opened, so this is a C# workspace. It becomes more a this folder was opened and contains files with these extensions meaning this may be a C# workspace.

@SeeminglyScience
Copy link

It does the same for me, seems like any time VSCode changes workspaces. Including just opening a new window with Ctrl + Shift + N. Here is it popping up for a workspace with just three log files:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants