Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Blazor WASM projects and add/update appropriate config to allow launching and debugging #3593

Merged
merged 8 commits into from Feb 26, 2020
Merged

Detect Blazor WASM projects and add/update appropriate config to allow launching and debugging #3593

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
099cffd
Detect Blazor WASM projects and add/update appropriate config.
NTaylorMullen Feb 20, 2020
0713ae5
Add understanding of Blazor hosted applications.
NTaylorMullen Feb 24, 2020
93a1ba6
Merge branch 'master' into nimullen/17549
JoeRobich Feb 25, 2020
ed00e1e
Merge branch 'master' into nimullen/17549
JoeRobich Feb 26, 2020
274633d
Restrict Blazor WASM asset additions
NTaylorMullen Feb 26, 2020
70e367c
Add prompt to users to indicate Blazor WASM debuggig is not configure…
NTaylorMullen Feb 26, 2020
625191e
Update Blazor WebAssembly prompt text.
NTaylorMullen Feb 26, 2020
17fdf62
Update Blazor notification text.
NTaylorMullen Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/omnisharp/utils.ts
View file
Open in desktop
Expand Up @@ -81,7 +81,7 @@ export async function requestWorkspaceInformation(server: OmniSharpServer) {
if (!blazorDetectionEnabled && response.MsBuild.Projects.some(project => isBlazorWebAssemblyProject(project))) {
// There's a Blazor Web Assembly project but VSCode isn't configured to debug the WASM code, show a notification
// to help the user configure their VSCode appropriately.
vscode.window.showInformationMessage('Your VSCode is not configured to debug Blazor web assembly applications.', 'Learn more', 'Close')
vscode.window.showInformationMessage('Additional setup is required to debug Blazor WebAssembly apps.', 'Learn more', 'Close')
NTaylorMullen marked this conversation as resolved.
Show resolved Hide resolved
.then(async result => {
if (result === 'Learn more') {
const uriToOpen = vscode.Uri.parse('https://aka.ms/blazordebugging#vscode');
Expand Down Expand Up @@ -223,4 +223,4 @@ function isWebProject(project: MSBuildProject): boolean {
// Assume that this is an MSBuild project. In that case, look for the 'Sdk="Microsoft.NET.Sdk.Web"' attribute.
// TODO: Have OmniSharp provide the list of SDKs used by a project and check that list instead.
return projectFileText.toLowerCase().indexOf('sdk="microsoft.net.sdk.web"') >= 0;
NTaylorMullen marked this conversation as resolved.
Show resolved Hide resolved
}
}