Fadeout unused variable names

[JoeRobich]

Currently unused variables are only faded out when omnisharp.enableRoslynAnalyzers is enabled. This change adds it to the list of compiler diagnostics we fadeout even when analyzers are disabled.

fixes #1324

[codecov]

Codecov Report

Merging #3733 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3733   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files          59       59           
  Lines        1777     1777           
  Branches      209      209           
=======================================
  Hits         1546     1546           
  Misses        176      176           
  Partials       55       55           

Flag	Coverage Δ
#integration	100.00% <ø> (ø)
#unit	87.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9776856...59dd38a. Read the comment docs.

[JoeRobich]

@brettfo PTAL

[filipw]

nice

[marcospgp]

I still don't see this functionality in VSCode as of today, is there a planned release date?

[JoeRobich]

@marcospgp If you are not seeing these in your vscode, it is most likely that the WarningLevel configured in your csproj is lower than 4. The compiler only reports these diagnostics when warning level is set to 4.

[marcospgp]

@JoeRobich Ok I think I found a bug with this functionality then, take a look at this:

When you create a variable that references a field of the class, it no longer is identified as never used, even if you do never use it in the function.

[JoeRobich]

@marcospgp This seems to be a case covered by dotnet/roslyn#15695

[marcospgp]

Revisiting this today, I double checked that:

• My .csproj has a warning level of 4 (this is controlled by Unity automatically)
• I have enabled omnisharp.enableRoslynAnalyzers

But unused fields still are not faded out:

@JoeRobich @filipw