Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore screen size is bogus errors with ps #3961

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Conversation

JoeRobich
Copy link
Member

Fixes #3580

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #3961 into master will increase coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3961      +/-   ##
==========================================
+ Coverage   85.64%   85.92%   +0.27%     
==========================================
  Files          60       60              
  Lines        1853     1847       -6     
  Branches      216      215       -1     
==========================================
  Hits         1587     1587              
+ Misses        206      200       -6     
  Partials       60       60              
Flag Coverage Δ
#integration 100.00% <ø> (ø)
#unit 85.92% <0.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common.ts 56.17% <0.00%> (+3.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b80c6...a1d265c. Read the comment docs.

@JoeRobich
Copy link
Member Author

GitHub checks didn't update. CI is passing - https://travis-ci.org/github/OmniSharp/omnisharp-vscode/builds/716764234

@JoeRobich JoeRobich merged commit 9e059df into dotnet:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why can't omnisharp/vscode load this sln file?
1 participant