Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties to blazorwasm debug configuration. #4445

Merged
merged 6 commits into from
Mar 25, 2021
Merged

Add properties to blazorwasm debug configuration. #4445

merged 6 commits into from
Mar 25, 2021

Conversation

@NTaylorMullen
Copy link
Contributor

/cc @captainsafia

package.json Outdated
@@ -3263,6 +3263,37 @@
"default": true
}
}
},
"justMyCode": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sourceFileMap and justMyCode options should be included under the dotnet config flag. E.g. replace this changeset with:

                  "dotNetConfig": {
                    "description": "Options passed to the underlying .NET debugger. For more info, see https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger.md.",
                    "type": "object",
                    "required": [],
                    "default": {},
                    "properties": {
                      "justMyCode": {
                        "type": "boolean",
                        "description": "Optional flag to only show user code.",
                        "default": true
                      },
                      "sourceFileMap": {
                        "type": "object",
                        "description": "Optional source file mappings passed to the debug engine. Example: '{ \"C:\\foo\":\"/home/user/foo\" }'",
                        "additionalProperties": {
                          "type": "string"
                        },
                        "default": {
                          "<insert-source-path-here>": "<insert-target-path-here>"
                        }
                      },
                      "logging": {
                        "description": "Optional flags to determine what types of messages should be logged to the output window.",
                        "type": "object",
                        "required": [],
                        "default": {},
                        "properties": {
                          "exceptions": {
                            "type": "boolean",
                            "description": "Optional flag to determine whether exception messages should be logged to the output window.",
                            "default": true
                          },
                          "moduleLoad": {
                            "type": "boolean",
                            "description": "Optional flag to determine whether module load events should be logged to the output window.",
                            "default": true
                          },
                          "programOutput": {
                            "type": "boolean",
                            "description": "Optional flag to determine whether program output should be logged to the output window when not using an external console.",
                            "default": true
                          },
                          "engineLogging": {
                            "type": "boolean",
                            "description": "Optional flag to determine whether diagnostic engine logs should be logged to the output window.",
                            "default": false
                          },
                          "browserStdOut": {
                            "type": "boolean",
                            "description": "Optional flag to determine if stdout text from the launching the web browser should be logged to the output window.",
                            "default": true
                          },
                          "elapsedTiming": {
                            "type": "boolean",
                            "description": "If true, engine logging will include `adapterElapsedTime` and `engineElapsedTime` properties to indicate the amount of time, in microseconds, that a request took.",
                            "default": false
                          },
                          "threadExit": {
                            "type": "boolean",
                            "description": "Controls if a message is logged when a thread in the target process exits. Default: `false`.",
                            "default": false
                          },
                          "processExit": {
                            "type": "boolean",
                            "description": "Controls if a message is logged when the target process exits, or debugging is stopped. Default: `true`.",
                            "default": true
                          }
                        }
                      }
                    }
                  },
                  "browserConfig": {
                    "description": "Options based to the underlying JavaScript debugger. For more info, see https://github.com/microsoft/vscode-js-debug/blob/main/OPTIONS.md.",
                    "type": "object",
                    "required": [],
                    "default": {},
                    "properties": {
                      "outputCapture": {
                        "enum": [
                          "console",
                          "std"
                        ],
                        "description": "From where to capture output messages: the default debug API if set to `console`, or stdout/stderr streams if set to `std`.",
                        "default": "console"
                      }
                    }
                  }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed accordingly.

I noticed that logging property was originally outside of dotNetConfig, while in the original file that property was inside. Is this intentional?

@@ -3263,6 +3263,45 @@
"default": true
}
}
},
"dotNetConfig": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And one more thing: the logging option from the L3219 above should also be moved inside here.

Almost there!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property is now moved.

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for reacting to all the feedback given.

@captainsafia
Copy link
Member

@JoeRobich Looks like this needs a review from you.

This contributor is submitting a PR to update the extension config with some properties I forgot to update during the last insertion.

@JoeRobich
Copy link
Member

Merging this PR is currently blocked on microsoft/vscode#119822

@JoeRobich JoeRobich merged commit f7544cb into dotnet:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor WebAssembly debugger cannot launch an Edge version other than stable
4 participants