Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Razor to 6.0.0-alpha.1.21201.19 #4470

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

NTaylorMullen
Copy link
Contributor

  • For this to work it requires the latest omnisharp-roslyn release.
  • Aligns with the .NET 6.0 Preview3 runtime release & 16.10-Preview2 VS tooling release.

Wasn't able to fullly try this out because it looks like O#'s "latest" release blob storage is down?
image

Fixes dotnet/aspnetcore#30834

@@ -331,8 +331,7 @@
{
"id": "Razor",
"description": "Razor Language Server (Windows / x64)",
"url": "https://download.visualstudio.microsoft.com/download/pr/a1999a11-02b4-49cf-9716-bdf7fb656b0b/c2388ccf719057b1b8d29aab27173206/razorlanguageserver-win-x64-6.0.0-alpha.1.20575.5.zip",
"fallbackUrl": "https://razorvscodetest.blob.core.windows.net/languageserver/RazorLanguageServer-win-x64-6.0.0-alpha.1.20575.5.zip",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately working out where our own blob storage went. For now removing fallback url as it's not needed

src/razor/syntaxes/aspnetcorerazor.tmLanguage.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@NTaylorMullen
Copy link
Contributor Author

@captainsafia with this I get spammed for Blazor debugging prompts. I assume not expected?
image

@captainsafia
Copy link
Member

@NTaylorMullen Nope, not expected. The code that displays that prompt lives in the omnisharp-vscode repo so it's unrelated to the insertion.

Can you open an issue with more details and I'll take a look?

I don't think this should block the insertion given where the codepath lies as mentioned above.

@NTaylorMullen
Copy link
Contributor Author

package-lock.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
- For this to work it requires the latest omnisharp-roslyn release.

Fixes dotnet/aspnetcore#30834
@NTaylorMullen NTaylorMullen force-pushed the nimullen/razor.6.0.0-alpha.1.21201.19 branch from 3cd5ab0 to 2e29182 Compare April 7, 2021 18:24
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #4470 (2e29182) into master (994e9b9) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4470      +/-   ##
==========================================
- Coverage   69.00%   68.91%   -0.10%     
==========================================
  Files         109      109              
  Lines        4282     4282              
  Branches      741      741              
==========================================
- Hits         2955     2951       -4     
- Misses       1123     1126       +3     
- Partials      204      205       +1     
Flag Coverage Δ
integration 52.50% <ø> (-0.12%) ⬇️
unit 85.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/features/diagnosticsProvider.ts 76.85% <0.00%> (-5.56%) ⬇️
src/features/semanticTokensProvider.ts 86.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994e9b9...2e29182. Read the comment docs.

@NTaylorMullen NTaylorMullen merged commit 6298a27 into master Apr 7, 2021
@NTaylorMullen NTaylorMullen deleted the nimullen/razor.6.0.0-alpha.1.21201.19 branch April 7, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do VSCode release to absorb Razor .NET 6 compiler changes for 16.10-P2 alignment.
4 participants