Use new CompletionItem label API #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion namespaces in line.
|
This is what it looks like: /cc @dibarbet, hopefully VS itself will take advantage of the 3.17 LSP API soon so you can replicate over there. |
JoeRobich
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.58 brought a new completion item API that allows us to specify a description for the completion label. This will give us an experience more akin to VS for import completion, where the namespace of the item is always displayed, right-aligned and slightly faded, in the completion list. Anything else that Roslyn adds to InlineDescription here will automatically show up, but import completion is the only thing that uses it for now.
Closes #4640.