Pass env variables from vstest to debugger #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
commented
Mar 31, 2022
| @@ -333,7 +333,8 @@ export default class TestManager extends AbstractProvider { | |||
| debuggerEventsPipeName: debuggerEventsPipeName, | |||
| program: program, | |||
| args: args, | |||
| cwd: cwd | |||
| cwd: cwd, | |||
| env: environmentVariables, | |||
There was a problem hiding this comment.
@gregg-miskelly please review, I am not sure if I need to do additional merging on the existing result which is a collection of debugger config, over which the new configuration is spread. Can it have env on it already?
There was a problem hiding this comment.
No, you shouldn't need to. It is not valid according to the schema (see here).
gregg-miskelly
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5131
Passes on env variables from the test request to the debugger.