Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5171 #5372

Merged
merged 2 commits into from Sep 23, 2022
Merged

Fix #5171 #5372

merged 2 commits into from Sep 23, 2022

Conversation

Dryadxon
Copy link
Contributor

@Dryadxon Dryadxon commented Sep 14, 2022

Replaced the deprecated ProjectDiagnosticStatus event with the newer BackgroundDiagnosticStatus.
Now BackgroundWorkStatusBarObserver no longer shows the path to the project file, but this shouldn't be a big deal.
This will fix #5171, without relying on obsolete protocol features, or workaround the discovered issue.

Replaced the deprecated ProjectDiagnosticStatus event with
the newer BackgroundDiagnosticStatus.
Now BackgroundWorkStatusBarObserver no longer shows the
path to the project file, but this shouldn't be a big deal.
@dnfadmin
Copy link
Collaborator

dnfadmin commented Sep 14, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Thanks @Dryadxon!

src/omnisharp/EventType.ts Outdated Show resolved Hide resolved
Make EventType.ProjectDiagnosticStatus unusable

Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
@JoeRobich JoeRobich merged commit 55bc054 into dotnet:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems list broken when Roslyn Analyzer is enabled
3 participants