Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing properties/methods from header files #5

Closed
vijaytholpadi opened this issue Oct 3, 2018 · 3 comments
Closed

Missing properties/methods from header files #5

vijaytholpadi opened this issue Oct 3, 2018 · 3 comments

Comments

@vijaytholpadi
Copy link

vijaytholpadi commented Oct 3, 2018

Hello,

What did I attempt:
Using the framework using both ObjC and Swift projects. Trying both CocoaPods as well as directly importing the library into the project.

What did I expect to work:
Able to see the launchWithContentID and other methods to use the Library.

What happened instead:
The header file generated at:
https://github.com/OmniVirt/OmniVirt-iOS-SDK/blob/master/OmniVirtSDK.framework/Headers/OmniVirtSDK-Swift.h

@interface FullscreenVRPlayer : UIViewController
- (void)viewDidLoad;
- (void)dismissViewControllerAnimated:(BOOL)flag completion:(void (^ _Nullable)(void))completion;
@property (nonatomic, readonly) UIInterfaceOrientationMask supportedInterfaceOrientations;
@property (nonatomic, readonly) BOOL shouldAutorotate;
- (nonnull instancetype)initWithNibName:(NSString * _Nullable)nibNameOrNil bundle:(NSBundle * _Nullable)nibBundleOrNil OBJC_DESIGNATED_INITIALIZER;
- (nullable instancetype)initWithCoder:(NSCoder * _Nonnull)aDecoder OBJC_DESIGNATED_INITIALIZER;
@end


SWIFT_CLASS("_TtC11OmniVirtSDK8VRPlayer")
@interface VRPlayer : UIView <WKNavigationDelegate>
- (nonnull instancetype)init SWIFT_UNAVAILABLE;
+ (nonnull instancetype)new SWIFT_DEPRECATED_MSG("-init is unavailable");
- (nullable instancetype)initWithCoder:(NSCoder * _Nonnull)aDecoder OBJC_DESIGNATED_INITIALIZER;
- (void)layoutSubviews;
- (void)webView:(WKWebView * _Nonnull)webView decidePolicyForNavigationAction:(WKNavigationAction * _Nonnull)navigationAction decisionHandler:(void (^ _Nonnull)(WKNavigationActionPolicy))decisionHandler;
- (nonnull instancetype)initWithFrame:(CGRect)frame SWIFT_UNAVAILABLE;
@end

Is missing the methods to use the library. It also is missing important properties/methods on VRPlayer class too. Thereby making it impossible to use the library

The example apps also do not work with the latest frameworks builds.

@vijaytholpadi
Copy link
Author

Diving into the git-log shows that these methods were removed in the commit
c1cad47

Is there a different approach to be taken to use this SDK?

@vijaytholpadi
Copy link
Author

vijaytholpadi commented Oct 8, 2018

@nuuneoi @baddth @jasukkas Would you guys happen to have any input on this? Would greatly help.

@vijaytholpadi
Copy link
Author

This has been fixed in the latest release 1.6.0
https://github.com/OmniVirt/OmniVirt-iOS-SDK/releases/tag/v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant