Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopicMappingService: Improve IsVisible() support #11

Open
3 tasks
JeremyCaney opened this issue Oct 4, 2019 · 0 comments
Open
3 tasks

TopicMappingService: Improve IsVisible() support #11

JeremyCaney opened this issue Oct 4, 2019 · 0 comments
Assignees
@JeremyCaney
Labels
Area: Mapping Relates to one of the `ITopicMappingService` interfaces or implementations. Priority: 3 Status 0: Discussion Needs further evaluation of requirements and prioritization. Type: Improvement Improves the functionality or interface of an existing feature.
Projects
Feature Requests

Comments

@JeremyCaney
Copy link
Member

A previous commit, #885d9a6d, introduced a bypass for IsVisible() when adding topics to a collection via TopicMappingService. This introduced problems since some customers have a requirement to provide an index of topics that are hidden from the navigation using IsHidden. For that reason, this changed was rolled back in #cccf94c.

Ideally, we will reintroduce this with a more careful implementation. This should include:

  • A ValidateTopic() function to centralize checks for null, IsDisabled, IsHidden, and List.
  • Possibly refactoring of PopulateChildTopics() since it is no longer a primary entry point.
  • A [AllowHidden] attribute on properties to bypass the check for IsHidden.
@JeremyCaney JeremyCaney self-assigned this Oct 4, 2019
@JeremyCaney JeremyCaney added this to To do in Feature Requests Nov 10, 2019
@JeremyCaney JeremyCaney moved this from To do to In progress in Feature Requests Nov 23, 2019
@JeremyCaney JeremyCaney moved this from In progress to Done in Feature Requests Dec 9, 2019
@JeremyCaney JeremyCaney added Area: Mapping Relates to one of the `ITopicMappingService` interfaces or implementations. Priority: 3 Status 0: Discussion Needs further evaluation of requirements and prioritization. Type: Improvement Improves the functionality or interface of an existing feature. and removed enhancement labels Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeremyCaney JeremyCaney

Labels
Area: Mapping Relates to one of the `ITopicMappingService` interfaces or implementations. Priority: 3 Status 0: Discussion Needs further evaluation of requirements and prioritization. Type: Improvement Improves the functionality or interface of an existing feature.
Projects
No open projects
Feature Requests
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyCaney