Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIDE YOUR OPENSEA API KEY #529

Closed
unover opened this issue Apr 14, 2022 · 3 comments
Closed

HIDE YOUR OPENSEA API KEY #529

unover opened this issue Apr 14, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@unover
Copy link

unover commented Apr 14, 2022

No description provided.

@loatheb
Copy link
Contributor

loatheb commented Apr 15, 2022

Thanks,I think this is a client side API token.The best way is using a environment variable and inject at bundle process. But even if using a environment variable, people can still see it at web request or javascript bundle result.

If this is a security related token or development used token, it is important to hide at souce code and using a server to proxy. Currently both OPENSEA API token or SENTRY_DSN and INFRUA API token are not secuity token.

But we will eventually put it in the environment variable at last, and it is currently the test version of the application for better local use.

@loatheb loatheb added enhancement New feature or request good first issue Good for newcomers labels Apr 15, 2022
@unover
Copy link
Author

unover commented Apr 28, 2022

API has a request limit by key, when you make it public - anyone can use it and you will have more throttled requests

@loatheb
Copy link
Contributor

loatheb commented May 5, 2022

@unover

Thanks! We have revoke all OPENSEA API KEY and COVALANT_API_KEY in our code. Currently we are using environment variable to inject., Instead of hardcode into source code.We didn't clear the git history because the token was useless.

Otherwise, the reason we didn't use a server proxy was that we wanted to keep the third-party services we used more transparent. And, although we inject through environment variables, these client tokens can still be seen in the final packaging result and runtime.

@loatheb loatheb closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants