Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Shared instance used in 'complete' method #630

Closed
3 tasks done
ilia-grishakov-m10 opened this issue Dec 27, 2022 · 2 comments
Closed
3 tasks done

[Bug]: Shared instance used in 'complete' method #630

ilia-grishakov-m10 opened this issue Dec 27, 2022 · 2 comments

Comments

@ilia-grishakov-m10
Copy link

ilia-grishakov-m10 commented Dec 27, 2022

What happened?

When use ur own instance of OneSignal through constructor instead of .shared instance there is method, that use forced .shared instance

Steps to reproduce?

1. notification.dart file, 392 line

What did you expect to happen?

use not shared instance instead

OneSignal Flutter SDK version

3.4.1

Which platform(s) are affected?

  • iOS
  • Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@brismithers
Copy link
Contributor

@ilia-grishakov-m10 the general expectation is that you use OneSignal.shared to access the SDK, as the underlying native SDKs are also static. Can you help us understand the scenario you are trying to cover by creating your own instance?

Regarding notification.dart line 392 using OneSignal.shared to complete the notification, is there an underlying issue that you are seeing?

Thanks!

@jennantilla
Copy link
Contributor

Closing due to no response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants