Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If user deleted from OneSignal dashboard, wipe client-side data #75

Closed
jasonpang opened this issue Jun 2, 2016 · 8 comments
Closed

Comments

@jasonpang
Copy link
Contributor

It's not intuitive that deleting a user from the OneSignal dashboard still leaves behind client-side data on the browser. IndexedDB should be wiped and the service worker should be unregistered (if possible, on HTTPS) if we get a no user with this ID found error indicating the user is deleted.

@jasonpang
Copy link
Contributor Author

jasonpang commented Jun 8, 2016

A table of APIs that, when called, return the specified error if the user has been deleted from the dashboard:

API Call "User not found" Error Message
sendTag(), sendTags(), deleteTag(), deleteTags(), setSubscription() No user with this id found
getTags() Could not find app_id for given player id.

@jasonpang
Copy link
Contributor Author

New Behavior

If a user deletes their entry from the dashboard, and a user ...

  • Refreshes the same page
    • Nothing will happen and the browser state will remain uncleared
  • Opens a new tab or window to their auto-registering HTTPS site
    • The user will get a new user ID and a new user entry will be created. Browser data will be updated automatically
  • Opens a new tab or window to their HTTP site
    • Nothing will happen and the browser state will remain uncleared; auto-resubscribing doesn't work for HTTP yet
  • Triggers any API call listed in the previous comment
    • IndexedDB is cleared, and the user is unsubscribed from push notifications. The service worker is not removed, this seems to cause an issue where navigator.serviceWorker.ready hangs when testing so it seems unreliable for now. Unsubscribing seems to be enough to get a new user ID.

@jasonpang
Copy link
Contributor Author

Implemented by: 83f99c9

@ejlocop
Copy link

ejlocop commented Feb 1, 2019

Hi, It seems like it's still not wiping the user's data on my browser.
I still get No user with this id found error when I try to execute this code.

OneSignal.sendTag('email', 'dev@example.com')

note: I also deleted the user in the OneSignal dashboard.

@geenloop
Copy link

still the same problem, after deleting on OneSignal dashboard.... web app stop communicate at all

@pkavanaghjr
Copy link

+1

I have deleted users from the OneSignal dashboard and now when the same user tries to interact with the SDK or REST API, it keeps saying "No user with this id found"

Looking for a way to flush the current ID's so user's can subscribe as if it's their first time being asked.

@ghost
Copy link

ghost commented Jan 28, 2020

I'm also experiencing this issue.

@dmitry
Copy link

dmitry commented Mar 25, 2021

Deleted onesignal IndexedDB from applications in chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants