Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: W3 validor failure in the OneSignal SDK <script> tag #319

Closed
1 task done
Hercilio1 opened this issue Nov 22, 2023 · 1 comment
Closed
1 task done

[Bug]: W3 validor failure in the OneSignal SDK <script> tag #319

Hercilio1 opened this issue Nov 22, 2023 · 1 comment

Comments

@Hercilio1
Copy link

What happened?

After running the w3 validator on my website, I got the following error on the <script> tag responsible for requesting the OneSignal SDK JS.

The error is the following:
image

The HTML code with the error is the following:
image

Wordpress version

6.4.1

OneSignal Plugin version

2.4.0

Steps to reproduce?

Just need to install and activate the plugin and configure the OneSignal account.

What did you expect to happen?

The script should be loaded via wp_enqueue_script or with a correct HTML with ASCII. Ex:

<script src="https://cdn.onesignal.com/sdks/OneSignalSDK.js?ver=6.4.1" async="async" id="remote_sdk-js"></script>

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@marclucraft
Copy link
Contributor

@Hercilio1 Thanks for your reporting, and your patience.

This has been addressed in #324, so will be fixed in the next release.

For now, you can update onesignal-public.php in your plugin directory, with the version in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants