Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mac Catalyst Build Breaks with Latest Release #1445

Open
1 task done
webbpage opened this issue May 29, 2024 · 11 comments · Fixed by #1446
Open
1 task done

[Bug]: Mac Catalyst Build Breaks with Latest Release #1445

webbpage opened this issue May 29, 2024 · 11 comments · Fixed by #1446

Comments

@webbpage
Copy link

webbpage commented May 29, 2024

What happened?

Release 5.2.0 build breaks for Mac Capacitor apps since there is no way to remove OneSignalLiveActivities.

Steps to reproduce?

Install OneSignal 5.2.0 with OneSignalXCFramework 5.2.0 (Capacitor App)
Try to deploy to Mac Catalyst. 
Errors occur related to OneSignalLiveActivities.

What did you expect to happen?

I expected the ability to turn off OneSignalLive, vs resorting to previous release.

OneSignal iOS SDK version

Release 5.2.0

iOS version

16

Specific iOS version

iOS 16.2

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jesus-mg-ios
Copy link

Same issue here

@nan-li
Copy link
Contributor

nan-li commented May 29, 2024

Hi @webbpage and @jesus-mg-ios thanks for reporting this. We will take a look at this version and Mac Catalyst.

@nan-li
Copy link
Contributor

nan-li commented May 29, 2024

@webbpage can you share the Errors occur related to OneSignalLiveActivities you see?

@jesus-mg-ios are you using the native iOS SDK or a cross-platform SDK?

@jesus-mg-ios
Copy link

The native one, While building for Mac Catalyst, no library for this platform was found in '/Volumes/workspace/DerivedData/SourcePackages/artifacts/onesignal-xcframework/OneSignalLiveActivities/OneSignalLiveActivities.xcframework'.

@webbpage
Copy link
Author

Same error received in cross-platform Capacitor SDK.

@nan-li
Copy link
Contributor

nan-li commented May 29, 2024

Thanks I reproduced this and will add Mac Catalyst to supported destinations

@nan-li
Copy link
Contributor

nan-li commented Jun 19, 2024

Hi everyone, the fix for this is in Release 5.2.1. We will need to still update our cross-platform SDKs with this update.

@webbpage
Copy link
Author

webbpage commented Jun 25, 2024

I'm still getting this error with 5.2.1.

Are we suppose to do anything different our end for catalyst? iOS still works after the update.

Screenshot 2024-06-25 at 5 23 01 PM

@nan-li
Copy link
Contributor

nan-li commented Jun 25, 2024

Hi @webbpage thanks for following up. There shouldn't be any additional steps. I'll take a look.

@webbpage
Copy link
Author

Thank you for looking. Once confirmed, can you please put this bug back into open status? Please do not hesitate to reach out if you need anything from me.

@nan-li nan-li reopened this Jun 26, 2024
@webbpage
Copy link
Author

@jesus-mg-ios were you able to confirm you still had an issue with 5.2.1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants