Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sound effect support #146

Open
joeyscarim opened this issue Nov 28, 2022 · 3 comments
Open

sound effect support #146

joeyscarim opened this issue Nov 28, 2022 · 3 comments
Assignees
Labels
Enhancement / Feature New feature or request

Comments

@joeyscarim
Copy link

Is there a way to add a sound effect when using the expo package?

i don’t see any mention of expo in https://documentation.onesignal.com/docs/customize-notification-sounds

@brismithers
Copy link
Contributor

Hi @joeyscarim unfortunately not without ejecting to a bare workflow at this time. I will flag this up as a feature request to support custom sounds, configuration would be similar to the icon support we recently added via #136

@brismithers brismithers added the Enhancement / Feature New feature or request label Nov 29, 2022
@vitorclelis96
Copy link

vitorclelis96 commented Jan 4, 2023

I'm a bit late, but I'll post here for anyone in the future:
You can use expo-notifications together with this plugin to make custom sounds work. Just follow the guide on how to configure your app.json file with expo-notifications plugin, then you can follow this guide from Onesignal itself, following IoS/Android standards, because the files will be "injected" (bundled) into your app (see here) through the expo-notifications plugin.
Hope it helps!

@tsheaff
Copy link

tsheaff commented Aug 2, 2023

+1 for wanting to see this feature in the plugin. It would be great is there was just a pushSounds option in the confi options just like largeIcons and smallIcons, and that could just be an array of paths to .wav or other push sound files. The plugin would then handle the native code piece of adding those to the Xcodeproj or the Android Build without having to eject (or include the expo-notifications package)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement / Feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants