Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location dropdown a bit mangled #103

Open
lentinj opened this issue Jun 18, 2018 · 6 comments
Open

Location dropdown a bit mangled #103

lentinj opened this issue Jun 18, 2018 · 6 comments
Labels
Version 3.6 nice to have Publication revision and sponsorship renewals

Comments

@lentinj
Copy link
Collaborator

lentinj commented Jun 18, 2018

In all views, the arrow markings look like they've gone a bit wrong.

@jrosindell What are they supposed to look like?

@jrosindell
Copy link
Member

What arrows do you mean?

There used to be directional arrows pointing down the tree with the highlighting function.

However, in the latest version of the code I decided they were not necessary so I cut them and you just get a smooth line broken at each node (so it looks like a dotted line) I chose this because it was simple, visually appealing (in my view at least!) and easy to generalise to marking the same branch with unlimited numbers of different colours for advanced search mode.

@jrosindell
Copy link
Member

jrosindell commented Jun 18, 2018

If you look at the live site - that's all working fine... so V 3.3 should behave the same unless it's an obvious bug or an improvement that we've decided with Naziha is needed.

@lentinj
Copy link
Collaborator Author

lentinj commented Jun 19, 2018

Here's a screenshot:

image

The dividers between each item have pushed the width of the pop-up out beyond what it should be, causing whitespace to the right of "Current Location", etc.

I had a brief look at how these were implemented, but wasn't sure what the intention was.

@hyanwong
Copy link
Member

Yes, that's a longstanding bug because of my poor css.

The intention is to show what fraction of the total number above are in the next category. It was previously implemented by James using tiny html5 canvases, but I reimplemented it badly in css using borders. If you can see how to get it to align properly, that would be great.

Yan

@jrosindell
Copy link
Member

This is a replicate of #25 hence I'm closing the other issue and leaving this open

@jrosindell
Copy link
Member

This is also related to #37

@jrosindell jrosindell added Version 3.6 nice to have Publication revision and sponsorship renewals and removed Version 3.3 nice to have labels Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version 3.6 nice to have Publication revision and sponsorship renewals
Projects
None yet
Development

No branches or pull requests

3 participants