Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete flowvision.models._util #110

Merged
merged 3 commits into from Jan 26, 2022
Merged

delete flowvision.models._util #110

merged 3 commits into from Jan 26, 2022

Conversation

kaijieshi7
Copy link
Contributor

  1. flowvision.models下面有_utils.pyutils.py
  2. IntermediateLayerGetter方法在flowvision.models._utils.pyflowvision.models.segmentation.seg_utils.py重复。

所以删除flowvision.models._utils.py,并暂时引用flowvision.models.segmentation.seg_utils.py

@rentainhe
Copy link
Contributor

  1. flowvision.models下面有_utils.pyutils.py
  2. IntermediateLayerGetter方法在flowvision.models._utils.pyflowvision.models.segmentation.seg_utils.py重复。

所以删除flowvision.models._utils.py,并暂时引用flowvision.models.segmentation.seg_utils.py

可以再看看这个方法有没有在det模型里用到。。我不太确定

@kaijieshi7
Copy link
Contributor Author

  1. flowvision.models下面有_utils.pyutils.py
  2. IntermediateLayerGetter方法在flowvision.models._utils.pyflowvision.models.segmentation.seg_utils.py重复。

所以删除flowvision.models._utils.py,并暂时引用flowvision.models.segmentation.seg_utils.py

可以再看看这个方法有没有在det模型里用到。。我不太确定

用到了,但是flowvision.models.segmentation.seg_utils.py里面有一样的方法。引用flowvision.models._utils.py我就暂时改到flowvision.models.segmentation.seg_utils.py这个引用了

@rentainhe
Copy link
Contributor

@simonJJJ 世杰有时间的话可以来帮忙一起看看这个问题,现在有2个utils.py,感觉需要干掉一个2333,不知道改成什么名字比较合适

@simonJJJ
Copy link
Contributor

这个我记得在检测里的BackboneWithFpn里有用到,不建议单独放在segmentation下,建议放在models下

@rentainhe
Copy link
Contributor

这个我记得在检测里的BackboneWithFpn里有用到,不建议单独放在segmentation下,建议放在models下

是的,感觉是放在models下,但是命名为_utils.py确实有点冲突,感觉换成一个什么别名比较合适~

@simonJJJ simonJJJ closed this Jan 21, 2022
@simonJJJ simonJJJ reopened this Jan 21, 2022
@simonJJJ
Copy link
Contributor

_utils.py我觉得可以,或者用更直接的layer_getter.py

@rentainhe
Copy link
Contributor

_utils.py我觉得可以,或者用更直接的layer_getter.py

如果里面只会放这个功能的话,我感觉改成layer_getter.py不错~ @kaijieshi7 可以参考一下

@kaijieshi7
Copy link
Contributor Author

_utils.py我觉得可以,或者用更直接的layer_getter.py

如果里面只会放这个功能的话,我感觉改成layer_getter.py不错~ @kaijieshi7 可以参考一下

已改

@rentainhe
Copy link
Contributor

_utils.py我觉得可以,或者用更直接的layer_getter.py

如果里面只会放这个功能的话,我感觉改成layer_getter.py不错~ @kaijieshi7 可以参考一下

已改

诶我印象里segmentation里也有用到,是不是segmentation里也要改了

from .seg_utils import _SimpleSegmentationModel, IntermediateLayerGetter

rentainhe
rentainhe previously approved these changes Jan 26, 2022
@rentainhe rentainhe merged commit db81c53 into main Jan 26, 2022
@rentainhe rentainhe deleted the revise_util branch January 26, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants