New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Poolformer #137
Support Poolformer #137
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
还有一点以后加模型的时候,都要添加和torch的速度对比数据,作为todo的一项,列在pr里面 |
是不是有脚本可以直接跑个测速 |
https://github.com/Oneflow-Inc/vision/blob/main/ci/check/run_speed_test.sh |
好的👌 |
我简单写个文档吧 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码小问题很多。需要严谨的对待发现的小问题。
是的,复制的地方比较多,在merge之前认真过一遍,多谢指正~ |
这个源码有个地方有问题,暂时别合并 |
我们去检查一下poolformer的源码吧 |
是我搞错了,不是很致命的问题。 |
记得README里也要修改一下~ |
需要做得精细一点,即使Group Norm被绕过但还是慢了一点,可以profile看看具体哪里慢了,可以和白夏颖交流。 |
意思就是你不用关心GN,在OneFlow和PyTorch都不用GN的情况下寻找一下为什么OneFlow还是慢一点,参考:https://github.com/Oneflow-Inc/OneTeam/issues/1020 |
@kaijieshi7 @Ldpe2G 各位再Review一下这个代码,然后没什么的话我们就先合并进去,速度问题再单独开一个Issue去跟踪,这样不会影响模型库的搭建速度 |
这个PR merge一下main之后可以合并了~ |
Support Poolformer