Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the compatibility of OptiFine. #28

Merged
merged 1 commit into from Jun 10, 2020
Merged

Fix the compatibility of OptiFine. #28

merged 1 commit into from Jun 10, 2020

Conversation

ZekerZhayard
Copy link
Contributor

@ZekerZhayard ZekerZhayard commented Jun 8, 2020

Fix #8.
I noticed that this issue has existed for a long time. This PR can let the injector inject into multiple methods with different parameters.
I haven't found a way to add additional mappings to Fabric Mixin, so I can't replace writeItemStack(Lnet/minecraft/class_1799;Z)Lnet/minecraft/class_2540; to writeItemStack(Lnet/minecraft/item/ItemStack;Z)Lnet/minecraft/util/PacketByteBuf;.

@Pyrofab Pyrofab added bug Something isn't working optifine labels Jun 10, 2020
@Pyrofab
Copy link
Member

Pyrofab commented Jun 10, 2020

This is great, thank you for the contribution!

@Pyrofab Pyrofab merged commit a0faf40 into Ladysnake:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working optifine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash at Startup
2 participants