feat: network fees from gas station #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Open-Attestation/maintainers For review. |
zixiang2018
reviewed
Nov 14, 2023
| } | ||
| }; | ||
|
|
||
| const safeParseUnits = (_value: number | string, decimals: number): BigNumber => { |
There was a problem hiding this comment.
I saw in line 39 which states to Pad the fraction to 9 decimal places, would it be better to set the param decimals to a default value of 9?
There was a problem hiding this comment.
I was thinking would it be better if we default the decimals in gasStation function instead? Like this: a16021b#diff-609663441672651e69555c0a1ae9ed0a7ec39717d6a59f38c05484b904018362R8-R9
Then the safeParseUnits (which I modified from ethersjs btw) can remain generic.
zixiang2018
approved these changes
Nov 14, 2023
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the Polygon gas station for the calculation of fees. The implementation can be extended to other networks that wish to rely on a gas station for their gas fees too. This should also resolve an issue with the current CLI implementation when sending transactions on the Polygon mainnet.
Changes