Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpackget] Installing a new pack skipping version check #168

Open
jeromecoutant opened this issue Mar 31, 2023 · 2 comments
Open

[cpackget] Installing a new pack skipping version check #168

jeromecoutant opened this issue Mar 31, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jeromecoutant
Copy link

Hi

During some development phase, we could need to force to install a pack even if the version is not the latest.

I would like to avoid this kind of error:

$ cpackget add STMicroelectronics.xxx
...
D: Reading pdsc from file "csfBBsSQAr\STMicroelectronics.xxx.pdsc"
D: Making sure xxx is the latest release in STMicroelectronics.xxx.pdsc
E: The pack's pdsc (STMicroelectronics.xxx.pdsc) has no release tag matching version "xxx"
E: pack version not found in the pdsc file

Proposition is to add a new option: --no-version-check ?

$ cpackget add -h
...
Flags:
  -a, --agree-embedded-license       agrees with the embedded license of the pack
  -x, --extract-embedded-license     extracts the embedded license of the pack and aborts the installation
  -F, --force-reinstall              forces installation of an already installed pack
  -h, --help                         help for add
  -n, --no-dependencies              do not install package dependencies
  --no-version-check                 do not check release tag
  -f, --packs-list-filename string   specifies a file listing packs urls, one per line

Then check in https://github.com/Open-CMSIS-Pack/cpackget/blob/main/cmd/installer/pack.go#L186
is skipped.

Thx

@LMESTM @PierreLeCorre

@jeromecoutant jeromecoutant added the enhancement New feature or request label Mar 31, 2023
@jkrech jkrech assigned thorstendb-ARM and unassigned lud0v1c Mar 31, 2023
@jkrech
Copy link
Member

jkrech commented Mar 31, 2023

@jeromecoutant,
FYI: the new maintainer of the cpackget repo is @thorstendb-ARM

Sorry, I do not understand your problem yet. Note that this is usually not an arbitrary version check that can be skipped, at least not, if the task is to install a public pack.

Could you maybe refine your command line, what does xxx include? Is it just the name of the pack or also a version?

cpackget add STMicroelectronics.xxx
cpackget add Keil.ARM_Compiler

checks whether any version of this pack is already installed. If not it installs the latest available version.

cpackget add Keil.ARM_Compiler.1.0.0

checks whether version 1.0.0 is listed in the <releases> section of the pdsc file in the .Web folder of CMSIS_PACK_ROOT. If it exists it will attempt to download and install this pack version.

cpackget add Keil.ARM_Compiler.0.0.1

Version 0.0.1 does not exist in the Keil.ARM_Compiler.pdsc file in the .Web folder, therefore the tool will raise an error:

E: pack version not found in the pdsc file

But you seem to have another use case for getting this error message.

Does the version information in the pack file (Keil.ARM_Compiler..pack) not match the version attribute of the top entry tag of the contained pdsc file (Keil.ARM_Compiler.pdsc)?

@jeromecoutant
Copy link
Author

FYI: the new maintainer of the cpackget repo is @thorstendb-ARM

Note the assignment is automatic, I didn't choose any one :-)

About my issue, we are releasing a pack version with several steps.
At each step, pack version is a little bit different, but internal pdsc content is the same (the final version).

@jkrech jkrech changed the title Installing a new pack skipping version check [cpackget] Installing a new pack skipping version check Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants