Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbuild-idx.yml does not expand variables #1414

Open
ReinhardKeil opened this issue Apr 2, 2024 · 5 comments
Open

cbuild-idx.yml does not expand variables #1414

ReinhardKeil opened this issue Apr 2, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@ReinhardKeil
Copy link
Collaborator

ReinhardKeil commented Apr 2, 2024

Describe the bug
For layers, the cbuild-idx.yml does not expand variables

To Reproduce
Use the USB example with layers in the csolution.yml.

  target-types:
    - type: B-U585I-IOT02A
      board: STMicroelectronics::B-U585I-IOT02A
      variables:
        - Board-Layer: /Users/.../AppData/Local/Arm/Packs/Keil/B-U585I-IOT02A_BSP/2.0.0-dev0/Layers/IoT/Board.clayer.yml

The output in cbuild-idx.yml is:

build-idx:
  generated-by: csolution version 2.3.0-dev0
  cdefault: cdefault.yml
  csolution: USB.csolution.yml
  cprojects:
    - cproject: Device/HID/HID.cproject.yml
      clayers:
        - clayer: Device/HID/$Board-Layer$

Expected behavior

  cprojects:
    - cproject: Device/HID/HID.cproject.yml
      clayers:
        - clayer: /Users/.../AppData/Local/Arm/Packs/Keil/B-U585I-IOT02A_BSP/2.0.0-dev0/Layers/IoT/Board.clayer.yml

Environment (please complete the following information):

  • solution version 2.3.0-dev0
  • OS: Windows
@ReinhardKeil ReinhardKeil added the bug Something isn't working label Apr 2, 2024
@jkrech
Copy link
Member

jkrech commented Apr 2, 2024

One remark: The variables most likely are context (target-type) specific.
This would require the variable definition to be added to the context/configuration information.

@ReinhardKeil
Copy link
Collaborator Author

@jkrech, you are correct - it is only relevant when the context is known. Perhaps the layer information should be added under cbuilds: that list all the context. However it is not a bug.

@ReinhardKeil ReinhardKeil added question Further information is requested and removed bug Something isn't working labels Apr 2, 2024
@jkrech
Copy link
Member

jkrech commented Apr 2, 2024

We could display the variable definitions only?

cbuilds:
  -cbuild: Device/HID/HID.Debug+B-U585I-IOT02A.cbuild.yml
    project: HID
    configuration: .Debub+B-U585I-IOT02A
    variables:
      - Board-Layer: /Users/.../AppData/Local/Arm/Packs/Keil/B-U585I-IOT02A_BSP/2.0.0-dev0/Layers/IoT/Board.clayer.yml

@jkrech jkrech added enhancement New feature or request and removed question Further information is requested labels Apr 23, 2024
@ReinhardKeil
Copy link
Collaborator Author

Addressing #1428 should be sufficient. Hence I'm closing this one.

@ReinhardKeil
Copy link
Collaborator Author

Sorry I was wrong. Paths should be expanded in build information files, otherwise the IDE needs to deal with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants