Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissive project list for csolution.yml #376

Closed
slhultgren opened this issue Jun 16, 2022 · 5 comments
Closed

Permissive project list for csolution.yml #376

slhultgren opened this issue Jun 16, 2022 · 5 comments
Labels
discussion done indicates an issue's discussion is completed enhancement New feature or request proposal Proposal for change or extension

Comments

@slhultgren
Copy link
Collaborator

It would be very nice if the tooling could allow csolution.yml project list to include all projects necessary. (The schema only specifies that the project should contain path to the project file, format unspecified)

For example it should be possible to link to a CMakeLists.txt or MyCustomProject.
In this case Open-CMSIS tooling would ignore those unknowns and only care about the files that it recognizes, e.g. *.cproject.yml, *.csolution.yml, *.clayer.yml.

@jkrech
Copy link
Member

jkrech commented Jul 4, 2022

  projects:
    - project: ./App/app.cproject.yml
    - project: ./MySubmodul/CMakeLists.txt
    - project: ./MyCustomProject/MyProject.xyz

I assume that some other tool will be able to make sense of the project format being referenced and actually consider these files.
Should the Open-CMSIS tooling even attempt to build the solution? Isn't it likely that the build will fail without the artifacts created by the "unknown" projects?

@jkrech jkrech added enhancement New feature or request proposal Proposal for change or extension discussion Indicates an issue being in discussion labels Jul 4, 2022
@ReinhardKeil
Copy link
Collaborator

ReinhardKeil commented Dec 22, 2022

I think this is covered by https://github.com/Open-CMSIS-Pack/devtools/blob/main/tools/projmgr/docs/Manual/YML-Input-Format.md#prepost-build-steps

This just needs to be implemented

@slhultgren could you review and provide feedback?

@ReinhardKeil ReinhardKeil added discussion done indicates an issue's discussion is completed and removed discussion Indicates an issue being in discussion labels Dec 22, 2022
@ReinhardKeil
Copy link
Collaborator

@brondani are the prepost-build-steps already implemented?

@jkrech
Copy link
Member

jkrech commented Feb 21, 2023

@ReinhardKeil , no pre- and post-build steps are not supported yet.

@brondani
Copy link
Collaborator

From the #prepost-build-steps:

Tbd: potentially map to CMake add_custom_command.

Since this would require further CPRJ extensions I would rather plan the full CPRJ deprecation and implement the new CMakeLists generation before implementing prepost-build-steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion done indicates an issue's discussion is completed enhancement New feature or request proposal Proposal for change or extension
Projects
None yet
Development

No branches or pull requests

4 participants