Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prjmgr] Base files for configuration files are unconditionally created in case the file version matches the component version (bug) #773

Closed
RobertRostohar opened this issue Feb 28, 2023 · 4 comments · Fixed by #775
Assignees
Labels
bug Something isn't working

Comments

@RobertRostohar
Copy link

Generation of the PLM .base files seems inconsistent. Sometimes they are generated and sometimes not.

Using CMSIS-Toolbox V1.5.0.

This behavior can be seen in the following repo:
https://github.com/Open-CMSIS-Pack/AWS_MQTT_MutualAuth_SW_Framework

‘main’ branch (fdbe861)

All configuration files in RTE directories are present and initially without any .base files.

After running (converting target IP-Stack without schema check):
csolution convert -s Demo.csolution.yml -c Demo.Debug+IP-Stack -n

Board\IMXRT1050-EVKB\RTE\Board_Support\MIMXRT1052DVL6B: .base file generated for each file
Board\IMXRT1050-EVKB\RTE\Device\MIMXRT1052DVL6B: .base file generated for each file
Board\IMXRT1050-EVKB\RTE\Compiler: .base file not generated
Board\IMXRT1050-EVKB\RTE\CMSIS_Driver: .base file generated – expected since the component is not used

RTE\Security: .base file generated
RTE\RTOS: .base file not generated

After running (converting target AVH without schema check):
csolution convert -s Demo.csolution.yml -c Demo.Debug+AVH -n

Board\AVH_MPS3_Corstone-300\RTE\Device\SSE-300-MPS3: .base file generated only for 2 files
Board\AVH_MPS3_Corstone-300\RTE\Compiler: .base file not generated

Why is there a difference in handling .base files and what is expected?

@ReinhardKeil
Copy link
Collaborator

The csolution tool does not generate the .base file when there is already a config file in the directory (as it does not overwrite this file and does not know which version it was).

Only when the file is the first time added, it is generated.

@RobertRostohar
Copy link
Author

The .base files are generated even if a config file already exists - see details above.

@edriouk
Copy link
Collaborator

edriouk commented Feb 28, 2023

The .base files also created for the files with specified version if it the actual one.
I need to look what happens. I think that generated *.cprj file contains components with "fixed version" == current version => the .base files get created.

@jkrech
Copy link
Member

jkrech commented Feb 28, 2023

@edriouk there seems to be a glitch here somewhere.
I am using a very basic example from here: https://github.com/Open-CMSIS-Pack/vscode-get-started/
I am just looking at the device startup config files for ARMCM3.
I have no pack versions nor component versions specified.

for startup_ARMCM3.c always the file startup_ARMCM3.c.base@2.0.3 gets created.
for system_ARMCM3.c no base file is created.

Looking at the ARM.CMSIS.pdsc the only special thing I find is that the file version of startup_ARMCM3.c matches the component version. If I edit the ARM.CMSIS.pdsc and change the file version of the system_ARMCM3.c also to match the component version, then the base file gets unconditionally created also for this file.

@edriouk could you please fix this bug?

@jkrech jkrech added the bug Something isn't working label Feb 28, 2023
@jkrech jkrech changed the title PLM of configuration files [prjmgr] Base files for configuration files are unconditionally created in case the file version matches the component version (bug) Feb 28, 2023
@edriouk edriouk closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants