Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a default timeout for all requests #454

Closed
soxofaan opened this issue Jul 31, 2023 · 1 comment
Closed

Use a default timeout for all requests #454

soxofaan opened this issue Jul 31, 2023 · 1 comment
Labels
collect feedback good first issue low hanging fruit usability

Comments

@soxofaan
Copy link
Member

Connection objects allow setting a default timeout for all requests:

openeo-python-client/openeo/rest/connection.py

Line 63 in 32b2cf6

default_timeout: Optional[int] = None,

but it is None (unlimited) by default.

It's probably better to set a more practical timeout, e.g. 1 minute.
@soxofaan
Copy link
Member Author

soxofaan commented Aug 1, 2023

fixed by c4d809f

@soxofaan soxofaan closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
collect feedback good first issue low hanging fruit usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soxofaan