Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding additional parameters to jobs, services etc. #125

Open
m-mohr opened this issue Jun 25, 2022 · 7 comments
Open

Support adding additional parameters to jobs, services etc. #125

m-mohr opened this issue Jun 25, 2022 · 7 comments
Labels
enhancement New feature or request Feature Request Possible Features to add to the client

Comments

@m-mohr
Copy link
Member

m-mohr commented Jun 25, 2022

Support the additional parameters in create_job, create_service etc.
This could then be used to add e.g. the job_options parameter as used by VITO.
Unfortunately, the ... parameter in the functions is already used to pass things through to the JSON library. So either er want to split the data depending on whether the parameter is known by the JSON library, and otherwise pass it in the body. Or we add an additional paramater as proposed in the client dev guide and implemented also in the JS client.

Related issue: Open-EO/openeo-api#276
Related forum topic: https://discuss.eodc.eu/t/error-loading-sentinel-3-slstr/395/6

@m-mohr m-mohr added enhancement New feature or request Feature Request Possible Features to add to the client labels Jun 25, 2022
@soxofaan
Copy link
Member

Are there any known workarounds to inject custom job_options in the POST data of create_job?

For example, when using it with the VITO/CDSE back-ends users sometimes want to increase memory limits (e.g. executor-memory), which does not seem possible with the current openEO R client package.

@m-mohr
Copy link
Member Author

m-mohr commented Dec 19, 2023

Not that I'm aware of, just checked the code again, but I don't think there's a way right now to add additional parameters.
Shouldn't be difficult to add though.

  • I assume, ~4 hours implementation
  • some hours for a re-release, could be combined with the v2 process changes changes in SAP10, I think

Maybe something we could try to add to openEO Platform SAP10? @soxofaan

@flahn are you the only person who can release on CRAN?

@flahn
Copy link
Member

flahn commented Dec 19, 2023

@m-mohr I couldn't find anything specific about who can send in packages at CRAN. Might be that all authors can, but I'm not sure. But if there is a new version to be released, I can definitely take care of running checks and the submission to CRAN.

@soxofaan
Copy link
Member

soxofaan commented Jan 4, 2024

Maybe something we could try to add to openEO Platform SAP10? @soxofaan

Makes sense indeed.

@m-mohr
Copy link
Member Author

m-mohr commented Jan 4, 2024

Do you take over adding/proposing it for SAP10? @soxofaan

@soxofaan
Copy link
Member

soxofaan commented Jan 5, 2024

I added it to the "table topics" spreadsheet.
But to clarify: I don't think that VITO would be able to work on the implementation (we don't have people with enough R experience to do this in just 4 man hours, especially because it involves being careful about backward/forward compatibility )

@m-mohr
Copy link
Member Author

m-mohr commented Jan 5, 2024

Good. I could work on it in collaboration with Edzer and Florian (for release), I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Feature Request Possible Features to add to the client
Projects
None yet
Development

No branches or pull requests

3 participants