Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support x-ndjson response type for batch element requests #29

Open
abelhegedus opened this issue Apr 30, 2021 · 1 comment
Open

Support x-ndjson response type for batch element requests #29

abelhegedus opened this issue Apr 30, 2021 · 1 comment

Comments

@abelhegedus
Copy link
Contributor

Since 4.0, the POST "get all elements" call ( https://github.com/Open-MBEE/mmsri/blob/a96ad352b98fe9317581f6f179d6058b8c4af2aa/openapi/api-docs.yaml#L917 ) supports streaming x-ndjson response (
https://github.com/Open-MBEE/mmsri/blob/a96ad352b98fe9317581f6f179d6058b8c4af2aa/openapi/api-docs.yaml#L945 )

It would be useful to add this response type to the batch (PUT) requests where requesting the data for a set of elements ( https://github.com/Open-MBEE/mmsri/blob/a96ad352b98fe9317581f6f179d6058b8c4af2aa/openapi/api-docs.yaml#L948 )

@dlamoris
Copy link
Contributor

it makes sense to add support, but one difference between get all and client requested elements is we also return "not found" or "deleted" requested elements in the return json as 'rejected' currently, supporting ndjson means either not returning those or saving and 'marking' them in a compatible way, we're not sure yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants