-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support some kind of dicom-archives
style?
#22
Comments
good pointer Yarik! My guess this is a matter of symantics in the best case e.g., finding the right root folder if we can download an example dataset or two, we can easily test and fix this |
|
that reminds of me of whether we fixed the issue of our library getting stuck or having problems with with recursive symbolic links inside datalad. Probably not as I ended up making a hard copy of the dataset for our intern! Actually, if your time permits, helping us support datalad datasets would be a great contrib from your side. We can walk you through our internal setup and I am confident this is child's play for you :) |
more specifically, it would be a minor modification of https://github.com/Open-Minds-Lab/MRdataset/blob/cfd26e38735665d80dbf9e052bf8adf70ed0b0bd/MRdataset/dicom_dataset.py#L77 after creating a class from MRdataset.base import Project
class DicomArchiveDataset(Project): and some testing on a few examples. We are working on a deadline at the end of this week, but will look into it after. |
In heudiconv, and
reproin
heuristic in particular we not only convert to BIDS datasets, but also "archive" original DICOMs under thesourcedata/
in mirroring converted to BIDS data hierarchy. See e.g. https://datasets.datalad.org/?dir=/dbic/QA/sourcedata/sub-emmet/ses-20180531/fmap which accompanies nii.gz's in http://datasets.datalad.org/?dir=/dbic/QA/sub-emmet/ses-20180531/fmap .Since bids analytics are limited to metadata fields extracted, I thought it would have been cool for mrQA to just operate on those original DICOMs which we have. (BTW heudiconv can convert from DICOMs being wrapped in such tarballs -- comes handy) . But I do not think that mrQA is supporting that as part of the
dicom
style:The text was updated successfully, but these errors were encountered: