Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added projects route #9

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Added projects route #9

merged 5 commits into from
Feb 2, 2022

Conversation

Boomer3110
Copy link
Contributor

Description

Added a new route for projects

Motivation and Context

To update the OSC Website projects feature.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Boomer3110 Boomer3110 added the enhancement New feature or request label Feb 2, 2022
dat-adi
dat-adi requested changes Feb 2, 2022
View reviewed changes
Copy link
Member

@dat-adi dat-adi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, however, the documentation still does need to be updated with the route.
Can be done in a maintenance patch later on.

dat-adi
dat-adi approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@dat-adi dat-adi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation has been updated, and this looks good to be merged.

SVijayB
SVijayB approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@SVijayB SVijayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on the PR @Boomer3110.
Merging 🚀

@SVijayB SVijayB merged commit 2dd3dea into main Feb 2, 2022
@SVijayB SVijayB mentioned this pull request Feb 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dat-adi dat-adi dat-adi approved these changes

@SVijayB SVijayB SVijayB approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Boomer3110 @dat-adi @SVijayB