Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lastest stable ZeroMQ version #305

Closed
OttoAllmendinger opened this issue Oct 16, 2014 · 1 comment
Closed

Support lastest stable ZeroMQ version #305

OttoAllmendinger opened this issue Oct 16, 2014 · 1 comment
Labels

Comments

@OttoAllmendinger
Copy link
Contributor

ZeroMQ 4.0.5 is out: https://raw.githubusercontent.com/zeromq/zeromq4-x/master/NEWS

Our current dependency check is set to ==4.0.4: https://github.com/Open-Transactions/opentxs/blob/develop/CMakeLists.txt#L182

Also the libname changed from 3.1.0 to 4.0.0, we need to allow both. I think we can just use find_library(ZMQ_LIB NAMES zmq libzmq) for non-windows platforms.

Should we just use this module? It has better Windows support than we have: https://github.com/robertmaynard/Remus/blob/master/CMake/FindZeroMQ.cmake

@toxeus
Copy link
Contributor

toxeus commented Oct 16, 2014

@OttoAllmendinger we used to have just find_library(ZMQ_LIB NAMES zmq libzmq). But it would then pick the wrong lib for users that have multiple libzmq installations. Please compare 43785a0.

We learned at dotGo that if something is on GitHub it doesn't mean that's it's ready for production :) So we should probably test if it really supports Windows better. And we should also evaluate if it's worth to pull in 113 lines of code while we're doing fine with 25 which can actually be reduced, see #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants