Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated code warnings #17

Open
wernight opened this issue Feb 8, 2024 · 0 comments
Open

Deprecated code warnings #17

wernight opened this issue Feb 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@wernight
Copy link

wernight commented Feb 8, 2024

Affected Version(s): 1.0.8

PHP Version: 8.2 FPM

Webserver: Nginx

Browser: N/A

Description

Creation of dynamic property OwaSdk\Tracker\TrackerClient::$site_id is deprecated

Triggered from https://github.com/Open-Web-Analytics/owa-php-sdk/blob/master/src/Tracker/TrackerClient.php#L1236

How to reproduce

Just run the getting started sample code.

Possible Solution

Just declare $site_id member field (like the others) before assigning it.

Hotfix:

sed -i '/var $config;/a    var $site_id;' vendor/open-web-analytics/owa-php-sdk/src/Tracker/TrackerClient.php

Additional context

I see no recent update on this project for a few years, which I can understand, but wondering if you're still handling PR requests as I see some pending. Most of the fixes should be fairly trivial.

@wernight wernight added the bug Something isn't working label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant