Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ][Ruby] Add support for faraday 2.x #12074

Closed
ykitamura-mdsol opened this issue Apr 7, 2022 · 0 comments · Fixed by #12112
Closed

[REQ][Ruby] Add support for faraday 2.x #12074

ykitamura-mdsol opened this issue Apr 7, 2022 · 0 comments · Fixed by #12112

Comments

@ykitamura-mdsol
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Faraday 2.x is released: lostisland/faraday#1358

Describe the solution you'd like

Based on the UPGRADING guide, we need to make changes to the following files:

gemspec.mustache

Relax Faraday dependency and add s.add_runtime_dependency 'faraday-multipart'

{{#isFaraday}}
s.add_runtime_dependency 'faraday', '~> 1.0', '>= 1.0.1'
{{/isFaraday}}

api_client.mustache

Add require 'faraday/multipart' if Gem::Version.new(Faraday::VERSION) >= Gem::Version.new('2.0')

{{#isFaraday}}
require 'faraday'
{{/isFaraday}}

api_client_faraday_partial.mustache

Handle basic_auth like this to support both Faraday 1.x and 2.x.

I'm going to work on this if no one has already started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant