-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQ] add support for decimals in the python generator #13324
Comments
One could maybe add it by changing the mapping for its type to Decimal, but how would it interact with over validation where the type could be plain string with no formatting? |
I was thinking to essentially do as you say such that the For the use case you describe where no formatting is given, it would be treated as a string. If that sounds like a reasonable approach, we're looking for some guidance as to what code changes would need to be made. Wrt Thanks |
Experimental refers to the fact that it has been out for a shorter period of time and that we allow breaking changes to be made to that generator. If you version pin you should be fine.
Please give it a try and let me know if it meets your needs. It is not missing any major features. |
thanks, will give a try and revert back 👍 |
Hi Justin, I've had a try with the python-experimental generator. There seems to be a number of breaking changes between the it and the python one (which are reasonable and I suppose expected), but this does mean that adoption would take us longer to complete. I did manage to almost get a couple of calls working but we've hit a blocking issue:
So for now at least we are probably going to need to try to add the feature into the existing python one. Would you be able to provide some guidance as where in the generator code we would need to make the changes? Thanks |
Hi there, I just fixed your blocking issue in this PR which has been merged into master branch.
If you do want to move forward with a PR in the
|
Thanks for fixing that so quickly, I'll take a look at the experimental and python changes |
my mistake re-opening this |
Closing this because the current python generator in v6.2.0 and onward supports decimals |
Describe the solution you'd like
Add support to the
python
generator for the following:which would generate a field of type
decimal.Decimal
that is de/serialized across the wire as a string.I am aware that support has been added to the
python-experimental
as part of #11282 but we are looking for support in thepython
generator.Additional context
We'd be happy to raise a PR but are looking for a steer on what the required changes would be and how long it might take to implement.
Thanks
The text was updated successfully, but these errors were encountered: